Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: samples/swarm/swarm_ui_lib/observable/observable.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library observable; 5 library observable;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 part 'ChangeEvent.dart'; 9 part 'ChangeEvent.dart';
10 part 'EventBatch.dart'; 10 part 'EventBatch.dart';
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 } 265 }
266 266
267 void removeRange(int start, int length) { 267 void removeRange(int start, int length) {
268 throw new UnimplementedError(); 268 throw new UnimplementedError();
269 } 269 }
270 270
271 void insertRange(int start, int length, [initialValue = null]) { 271 void insertRange(int start, int length, [initialValue = null]) {
272 throw new UnimplementedError(); 272 throw new UnimplementedError();
273 } 273 }
274 274
275 List sublist(int start, [int end]) {
276 throw new UnimplementedError();
277 }
278
275 List getRange(int start, int length) { 279 List getRange(int start, int length) {
276 throw new UnimplementedError(); 280 throw new UnimplementedError();
277 } 281 }
278 282
279 bool contains(T element) { 283 bool contains(T element) {
280 throw new UnimplementedError(); 284 throw new UnimplementedError();
281 } 285 }
282 286
283 dynamic reduce(var initialValue, 287 dynamic reduce(var initialValue,
284 dynamic combine(var previousValue, T element)) { 288 dynamic combine(var previousValue, T element)) {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 // Only fire on an actual change. 339 // Only fire on an actual change.
336 if (!identical(newValue, _value)) { 340 if (!identical(newValue, _value)) {
337 final oldValue = _value; 341 final oldValue = _value;
338 _value = newValue; 342 _value = newValue;
339 recordPropertyUpdate("value", newValue, oldValue); 343 recordPropertyUpdate("value", newValue, oldValue);
340 } 344 }
341 } 345 }
342 346
343 T _value; 347 T _value;
344 } 348 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698