components/view_manager/public/cpp/lib/view_tree_client_impl.h - Issue 1281663002: Mandoline: Allow submitting CompositorFrames directly to mojo::Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/public/cpp/lib/view_tree_client_impl.h

Issue 1281663002: Mandoline: Allow submitting CompositorFrames directly to mojo::Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/view_manager/public/cpp/lib/view_surface.cc ('k') | components/view_manager/public/cpp/lib/view_tree_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/view_manager/public/cpp/lib/view_tree_client_impl.h

diff --git a/components/view_manager/public/cpp/lib/view_tree_client_impl.h b/components/view_manager/public/cpp/lib/view_tree_client_impl.h

index 1d300b0fd9d639f54ae5edcd14a4885d37ec248c..806ed4cf887e064a06929cc2276532af5ab2f995 100644

--- a/components/view_manager/public/cpp/lib/view_tree_client_impl.h

+++ b/components/view_manager/public/cpp/lib/view_tree_client_impl.h

@@ -41,7 +41,6 @@ class ViewTreeClientImpl : public ViewTreeConnection, public ViewTreeClient {

bool OwnsView(Id id) const;

void SetBounds(Id view_id, const Rect& bounds);

- void SetSurfaceId(Id view_id, SurfaceIdPtr surface_id);

void SetFocus(Id view_id);

void SetVisible(Id view_id, bool visible);

void SetProperty(Id view_id,

@@ -57,6 +56,10 @@ class ViewTreeClientImpl : public ViewTreeConnection, public ViewTreeClient {

ServiceProviderPtr exposed_services);

void Embed(Id view_id, ViewTreeClientPtr client);

+ void RequestSurface(Id view_id,

+ InterfaceRequest<Surface> surface,

+ SurfaceClientPtr client);

void set_change_acked_callback(const Callback<void(void)>& callback) {

change_acked_callback_ = callback;

}