components/view_manager/view_tree_impl.h - Issue 1281663002: Mandoline: Allow submitting CompositorFrames directly to mojo::Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/view_tree_impl.h

Issue 1281663002: Mandoline: Allow submitting CompositorFrames directly to mojo::Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased + added uip::Surface Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/view_manager/server_view.cc ('K') | « components/view_manager/view_manager_app.cc ('k') | components/view_manager/view_tree_impl.cc » ('j') | components/view_manager/view_tree_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/view_manager/view_tree_impl.h

diff --git a/components/view_manager/view_tree_impl.h b/components/view_manager/view_tree_impl.h

index e2d3779fac2e6b2b236d42f1751e3919079c5083..1113fe14e90b67b118260781176d4baecf1a8a8b 100644

--- a/components/view_manager/view_tree_impl.h

+++ b/components/view_manager/view_tree_impl.h

@@ -196,9 +196,6 @@ class ViewTreeImpl : public mojo::ViewTree, public AccessPolicyDelegate {

void GetViewTree(mojo::Id view_id,

const mojo::Callback<void(mojo::Array<mojo::ViewDataPtr>)>&

callback) override;

- void SetViewSurfaceId(mojo::Id view_id,

- mojo::SurfaceIdPtr surface_id,

- const mojo::Callback<void(bool)>& callback) override;

void SetViewBounds(mojo::Id view_id,

mojo::RectPtr bounds,

const mojo::Callback<void(bool)>& callback) override;

@@ -209,6 +206,10 @@ class ViewTreeImpl : public mojo::ViewTree, public AccessPolicyDelegate {

const mojo::String& name,

mojo::Array<uint8_t> value,

const mojo::Callback<void(bool)>& callback) override;

+ void RequestSurface(

+ mojo::Id view_id,

+ mojo::InterfaceRequest<mojo::Surface> surface,

+ mojo::SurfaceClientPtr client) override;

void SetEmbedRoot() override;

void Embed(mojo::Id transport_view_id,

mojo::ViewTreeClientPtr client,