mandoline/tab/frame_connection.cc - Issue 1281663002: Mandoline: Allow submitting CompositorFrames directly to mojo::Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/tab/frame_connection.cc

Issue 1281663002: Mandoline: Allow submitting CompositorFrames directly to mojo::Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a TODO Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/view_manager/public/interfaces/view_manager.mojom ('K') | « components/view_manager/view_manager_service_unittest.cc ('k') | mandoline/ui/aura/surface_binding.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mandoline/tab/frame_connection.cc

diff --git a/mandoline/tab/frame_connection.cc b/mandoline/tab/frame_connection.cc

index 5fa2ae4bdd837ea464e5cd2841521f7eab794896..fdd5409af328042e2e210a41e14acddb63bfa77c 100644

--- a/mandoline/tab/frame_connection.cc

+++ b/mandoline/tab/frame_connection.cc

@@ -8,7 +8,6 @@

#include "components/devtools_service/public/interfaces/devtools_service.mojom.h"

#include "components/resource_provider/public/interfaces/resource_provider.mojom.h"

#include "components/view_manager/public/interfaces/gpu.mojom.h"

-#include "components/view_manager/public/interfaces/surfaces.mojom.h"

#include "components/view_manager/public/interfaces/view_manager_root.mojom.h"

#include "mojo/application/public/cpp/application_connection.h"

#include "mojo/application/public/cpp/application_impl.h"

@@ -59,7 +58,6 @@ void FrameConnection::Init(mojo::ApplicationImpl* app,

mojo::Array<mojo::String> view_manager_interfaces;

view_manager_interfaces.push_back(mojo::Gpu::Name_);

view_manager_interfaces.push_back(mojo::ViewManagerRoot::Name_);

- view_manager_interfaces.push_back(mojo::Surface::Name_);

filter->filter.insert("mojo:view_manager", view_manager_interfaces.Pass());

mojo::Array<mojo::String> devtools_interfaces;