Mandoline: Allow submitting CompositorFrames directly to mojo::Views

components/view_manager/public/interfaces/view_manager.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module mojo;
 
+import "components/view_manager/public/interfaces/compositor_frame.mojom";
 import "components/view_manager/public/interfaces/surface_id.mojom";
 import "components/view_manager/public/interfaces/view_manager_constants.mojom";
 import "mojo/application/public/interfaces/service_provider.mojom";
 import "network/public/interfaces/url_loader.mojom";
 import "ui/mojo/events/input_events.mojom";
 import "ui/mojo/ime/text_input_state.mojom";
 import "ui/mojo/geometry/geometry.mojom";
 
 struct ViewportMetrics {
   Size size_in_pixels;
@@ skipping 51 matching lines @@
   // allowed to change the visibility of any view they have created, as well as
   // any of their roots.
   SetViewVisibility(uint32 view_id, bool visible) => (bool success);
 
   // Sets an individual named property. Setting an individual property to null
   // deletes the property.
   SetViewProperty(uint32 view_id,
                   string name,
                   array<uint8>? value) => (bool success);
 
+  // Sets the CompositorFrameReceiver on a particular view.
+  RequestCompositorFrameReceiver(uint32 view_id,
+                                 CompositorFrameReceiver& receiver);
+
   // Reparents a view.
   // This fails for any of the following reasons:
   // . |parent| or |child| does not identify a valid view.
   // . |child| is an ancestor of |parent|.
   // . |child| is already a child of |parent|.
   //
   // This may result in a connection getting OnViewDeleted(). See
   // RemoveViewFromParent for details.
   AddView(uint32 parent, uint32 child) => (bool success);
 
@@ skipping 97 matching lines @@
   OnEmbedForDescendant(uint32 view, URLRequest request) =>
       (ViewManagerClient? client);
 
   // Invoked when the application embedded at |view| is disconnected.
   OnEmbeddedAppDisconnected(uint32 view);
 
   // Sent when another connection is embedded in the View this connection was
   // previously embedded in. See Embed() for more information.
   OnUnembed();
 
+  // Sent when GPU resources are returned to the client for reuse.

[rjkroege, 2015/08/21 22:58:00]

These messages need to end up at cc.  in Phase2, they will go to impl-paint. In
either case, they should not go to main. But afaik, this endpoint goes to main
yes?

We can proxy the message through main in the short term if necessary but that is
most certainly the wrong architecture because it defeats the point of cc::impl.

Based on the SubmitCompositorFrame discussion, I propose that we need separate
On* interfaces for main, cw, impl-paint. WDYT?

[Fady Samuel, 2015/08/21 23:15:27]

Yes, I agree. Do you want me to change this in a separate patch? I'd rather not
iterate yet again here :-)

+  OnResourcesReturned(array<ReturnedResource> resources);
+
   // Invoked when a view's bounds have changed.
   OnViewBoundsChanged(uint32 view,
                       mojo.Rect old_bounds,
                       mojo.Rect new_bounds);
 
   // Invoked when the viewport metrics for the view have changed.
   // Clients are expected to propagate this to the view tree.
   OnViewViewportMetricsChanged(mojo.ViewportMetrics old_metrics,
                                mojo.ViewportMetrics new_metrics);
 
@@ skipping 33 matching lines @@
 
   // Invoked when a view property is changed. If this change is a removal,
   // |new_data| is null.
   OnViewSharedPropertyChanged(uint32 view, string name, array<uint8>? new_data);
 
   // Invoked when an event is targeted at the specified view.
   OnViewInputEvent(uint32 view, mojo.Event event) => ();
 
   OnViewFocused(uint32 focused_view_id);
 };