Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 128163002: Check for "Mali-Txxx" instead of "Mali-T6xx" (Closed)

Created:
6 years, 11 months ago by johnme
Modified:
6 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Check for "Mali-Txxx" instead of "Mali-T6xx" A contact at ARM mentioned that their recent Mali-T7xx line of GPUs doesn't guarantee flush ordering either (and there seems little reason to assume future models will break this trend). So instead of enabling use_virtualized_gl_contexts for GPUs starting with "Mali-T6", we should check for e.g. "Mali-T[6-9]", or more simply just "Mali-T" since older Mali GPUs didn't have a "T". BUG=154715 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243620

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
johnme
6 years, 11 months ago (2014-01-08 12:24:32 UTC) #1
Sami
lgtm % nit. I wonder if we should just bite the bullet and add regex ...
6 years, 11 months ago (2014-01-08 12:55:27 UTC) #2
no sievers
On 2014/01/08 12:55:27, Sami wrote: > lgtm % nit. I wonder if we should just ...
6 years, 11 months ago (2014-01-08 13:06:44 UTC) #3
Sami
I tested that this didn't break anything on a Nexus 10 (Mali-T604).
6 years, 11 months ago (2014-01-08 14:58:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/128163002/70001
6 years, 11 months ago (2014-01-08 15:04:20 UTC) #5
Ken Russell (switch to Gerrit)
LGTM FWIW
6 years, 11 months ago (2014-01-08 18:29:33 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 19:02:47 UTC) #7
Message was sent while issue was closed.
Change committed as 243620

Powered by Google App Engine
This is Rietveld 408576698