Issue 1281553004: Disable tap suppression logic for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1281553004: Disable tap suppression logic for WebView (Closed)

Created:
5 years, 4 months ago by jdduke (slow)

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews, jam, tdresser+watch_chromium.org, jdduke+watch_chromium.org, android-webview-reviews_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable tap suppression logic for WebView WebView embedders can suppress fling animation updates, potentially confusing the tap suppression controller. As the feature isn't critical, simply disable it for WebView. Also refactor the input router settings helper to use ui::GestureConfiguration directly for configuring tap suppression. This makes it simpler for different platforms to customize behavior. BUG=514783 Review URL: https://codereview.chromium.org/1267693004 Cr-Commit-Position: refs/heads/master@{#342019} (cherry picked from commit 36fee7bc622102a5a616a48262d54bdbe1d30903) Committed: https://chromium.googlesource.com/chromium/src/+/52180dcec6ff5c156fd1bb57af8798bbe4b67f46

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -64 lines)			Patch
M	android_webview/android_webview.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/lib/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/lib/main/aw_main_delegate.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/input/input_router_config_helper.cc	View	3 chunks	+30 lines, -64 lines	0 comments	Download
M	ui/events/gesture_detection/gesture_configuration.h	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	ui/events/gesture_detection/gesture_configuration.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/events/gesture_detection/gesture_configuration_android.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/events/gesture_detection/gesture_configuration_aura.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

5 years, 4 months ago (2015-08-06 18:43:35 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
52180dcec6ff5c156fd1bb57af8798bbe4b67f46.

Expand Messages | Collapse Messages