Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1281523004: Add readelf and nm dummy values to cros. (Closed)

Created:
5 years, 4 months ago by Peter Mayo
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, cdotstout
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add readelf and nm dummy values to cros. gn gen now requires them, but they have no values immediately available. BUG=517493 TEST=None Committed: https://crrev.com/d9c347b62ded29ffb33cc864dc44fc60a0708539 Cr-Commit-Position: refs/heads/master@{#342299}

Patch Set 1 #

Patch Set 2 : Ease requirement for readelf and nm. #

Patch Set 3 : Provide central default for readelf and nm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 2 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Peter Mayo
5 years, 4 months ago (2015-08-06 15:44:15 UTC) #2
Dirk Pranke
Can we fix the toolchain instead to not make these mandatory?
5 years, 4 months ago (2015-08-06 20:45:33 UTC) #3
Peter Mayo
Ease requirement for readelf and nm.
5 years, 4 months ago (2015-08-06 20:56:35 UTC) #4
Peter Mayo
Provide central default for readelf and nm.
5 years, 4 months ago (2015-08-06 21:16:33 UTC) #5
Peter Mayo
On 2015/08/06 20:45:33, Dirk Pranke wrote: > Can we fix the toolchain instead to not ...
5 years, 4 months ago (2015-08-06 21:19:10 UTC) #6
Dirk Pranke
I think this is probably fine; if some platform needs to do shared links but ...
5 years, 4 months ago (2015-08-06 21:30:10 UTC) #7
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-06 21:30:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281523004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281523004/40001
5 years, 4 months ago (2015-08-07 03:00:52 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-07 05:24:19 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 05:25:15 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9c347b62ded29ffb33cc864dc44fc60a0708539
Cr-Commit-Position: refs/heads/master@{#342299}

Powered by Google App Engine
This is Rietveld 408576698