Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1281483012: Remove net_resources.rc (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove net_resources.rc This seems to not be used. Committed: https://crrev.com/8efeb856153fb841772227d3e8cc71c74186061a Cr-Commit-Position: refs/heads/master@{#342895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M components/components_tests.gyp View 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/gpu/test_support_gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +4 lines, -6 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/net_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281483012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281483012/1
5 years, 4 months ago (2015-08-11 19:35:24 UTC) #2
brettw
Going to try to see if this sticks, and if so, do it for other ...
5 years, 4 months ago (2015-08-11 19:35:36 UTC) #4
scottmg
I don't see any unit test that refers to dir_header.html https://code.google.com/p/chromium/codesearch#search/&q=dir_header.html&sq=package:chromium&type=cs and it specifically allows ...
5 years, 4 months ago (2015-08-11 19:43:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-11 20:58:26 UTC) #7
brettw
On 2015/08/11 19:43:45, scottmg (returning - slow) wrote: > So maybe manually spot check a ...
5 years, 4 months ago (2015-08-11 21:03:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281483012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281483012/1
5 years, 4 months ago (2015-08-11 21:04:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 21:10:42 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 21:11:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8efeb856153fb841772227d3e8cc71c74186061a
Cr-Commit-Position: refs/heads/master@{#342895}

Powered by Google App Engine
This is Rietveld 408576698