Issue 1281463002: Preparation for changing SpdyHeaderBlock to be ordered. This just

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1281463002: Preparation for changing SpdyHeaderBlock to be ordered. This just (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)

Modified:
5 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Close_QUIC_connections_99369742

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Preparation for changing SpdyHeaderBlock to be ordered. This just reduces the number of files in upcoming CL by 2. No behavior change as these are currently entries into a map, and the key:value pairs haven't changed. However after changing to ordered SpdyHeaderBlock, the pseudo-header order of authority,path,scheme,method is what ends up getting written, and thus I'm changing the order here in advance. relnote: n/a (test only) Merge internal change: 99394725 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/quic/test_tools/quic_test_packet_maker.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	net/tools/quic/spdy_balsa_utils_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1277753002 Patch 1

Dependent Patchsets:

Issue 1276983003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages