Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1281453003: [test] Make test filters platform-independent. (Closed)

Created:
5 years, 4 months ago by Michael Achenbach
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make test filters platform-independent. Use the same path separator for test cases on the cmd-line on all platforms as in testcase.GetLabel, which is used to report failures. BUG=chromium:511215 LOG=n NOTRY=true Committed: https://crrev.com/7ce3afa0df92cad3c1ecc6ff350250f97fbc9d70 Cr-Commit-Position: refs/heads/master@{#30045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/run-tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 4 months ago (2015-08-06 09:37:47 UTC) #2
Jakob Kummerow
LGTM!!!!!!!!!!!!!111eleven
5 years, 4 months ago (2015-08-06 09:42:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281453003/1
5 years, 4 months ago (2015-08-06 12:35:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 12:36:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 12:37:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ce3afa0df92cad3c1ecc6ff350250f97fbc9d70
Cr-Commit-Position: refs/heads/master@{#30045}

Powered by Google App Engine
This is Rietveld 408576698