Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1281433002: Enable software decoding video with libvpx on Android (Closed)

Created:
5 years, 4 months ago by watk
Modified:
5 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable software decoding video with libvpx on Android VpxVideoDecoder previously would reject VP8 without an alpha channel, leaving it to be decoded by FFmpegVideoDecoder. Now, when it's compiled without FFmpegVideoDecoder it will handle all VP8. BUG=507834 Committed: https://crrev.com/dce82facb9614af36897f3c076e1842773871f1e Cr-Commit-Position: refs/heads/master@{#342405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/filters/vpx_video_decoder.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
watk
5 years, 4 months ago (2015-08-05 22:19:53 UTC) #2
DaleCurtis
lgtm, did you want to include the media.gyp / build.gn change to enable media_use_libvpx though?
5 years, 4 months ago (2015-08-05 22:39:24 UTC) #3
watk
On 2015/08/05 22:39:24, DaleCurtis wrote: > lgtm, did you want to include the media.gyp / ...
5 years, 4 months ago (2015-08-05 23:01:39 UTC) #4
DaleCurtis
Oh I see, yeah that seems fine with me. I forgot we deleted the build_ffmpegsumo ...
5 years, 4 months ago (2015-08-05 23:04:21 UTC) #5
DaleCurtis
https://codereview.chromium.org/1281433002/diff/20001/media/media_variables.gypi File media/media_variables.gypi (right): https://codereview.chromium.org/1281433002/diff/20001/media/media_variables.gypi#newcode27 media/media_variables.gypi:27: ['(OS == "android" and media_use_ffmpeg == 0) or OS ...
5 years, 4 months ago (2015-08-05 23:29:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281433002/1
5 years, 4 months ago (2015-08-06 00:10:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89395)
5 years, 4 months ago (2015-08-06 01:59:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281433002/1
5 years, 4 months ago (2015-08-07 02:45:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/96302)
5 years, 4 months ago (2015-08-07 03:57:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281433002/1
5 years, 4 months ago (2015-08-07 17:24:48 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 19:17:03 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:18:09 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dce82facb9614af36897f3c076e1842773871f1e
Cr-Commit-Position: refs/heads/master@{#342405}

Powered by Google App Engine
This is Rietveld 408576698