|
|
Created:
5 years, 4 months ago by watk Modified:
5 years, 4 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable software decoding video with libvpx on Android
VpxVideoDecoder previously would reject VP8 without an alpha
channel, leaving it to be decoded by FFmpegVideoDecoder. Now,
when it's compiled without FFmpegVideoDecoder it will handle
all VP8.
BUG=507834
Committed: https://crrev.com/dce82facb9614af36897f3c076e1842773871f1e
Cr-Commit-Position: refs/heads/master@{#342405}
Patch Set 1 #
Messages
Total messages: 19 (7 generated)
watk@chromium.org changed reviewers: + dalecurtis@chromium.org
lgtm, did you want to include the media.gyp / build.gn change to enable media_use_libvpx though?
On 2015/08/05 22:39:24, DaleCurtis wrote: > lgtm, did you want to include the media.gyp / build.gn change to enable > media_use_libvpx though? Hmm, I was just going to leave it as is for now (you have to set both variables). I can change it so that media_use_ffmpeg=1 implies media_use_libvpx=1 on Android?
Oh I see, yeah that seems fine with me. I forgot we deleted the build_ffmpegsumo variable.
https://codereview.chromium.org/1281433002/diff/20001/media/media_variables.gypi File media/media_variables.gypi (right): https://codereview.chromium.org/1281433002/diff/20001/media/media_variables.g... media/media_variables.gypi:27: ['(OS == "android" and media_use_ffmpeg == 0) or OS == "ios"', { I like your original idea of forcing media_use_libvpx for now and not this. Long term we would just flip these defaults.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281433002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dce82facb9614af36897f3c076e1842773871f1e Cr-Commit-Position: refs/heads/master@{#342405} |