Optimize RTL check in ICU to avoid mmap access.

base/i18n/rtl_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/rtl.h"
 
 #include <algorithm>
 
 #include "base/files/file_path.h"
 #include "base/strings/string_util.h"
@@ skipping 381 matching lines @@
   // Chinese in China with '-'.
   EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocale("zh-CN"));
   // Filipino : 3-letter code
   EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocale("fil"));
   // Russian
   EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocale("ru"));
   // Japanese that uses multiple scripts
   EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocale("ja"));
 }
 
+TEST_F(RTLTest, GetTextDirectionForLocaleInStartUp) {
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("ar"));
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("ar_EG"));
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("he"));
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("he_IL"));
+  // iw is an obsolete code for Hebrew.
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("iw"));
+  // Although we're not yet localized to Farsi and Urdu, we
+  // do have the text layout direction information for them.
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("fa"));
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("ur"));
+#if 0
+  // Enable these when we include the minimal locale data for Azerbaijani
+  // written in Arabic and Dhivehi. At the moment, our copy of
+  // ICU data does not have entries for them.
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("az_Arab"));
+  // Dhivehi that uses Thaana script.
+  EXPECT_EQ(RIGHT_TO_LEFT, GetTextDirectionForLocaleInStartUp("dv"));
+#endif

[jungshik at Google, 2015/08/11 19:23:13]

I don't think we need these #if-0'd lines because we're not likely to localize
to az_Arab and dv (Chromium may do, but not Google Chrome) in the near future.
Get..Startup is for UI locales we localized to because it's used to determine
the overall UI direction. 

[danduong, 2015/08/11 20:01:10]

Removed the if-0 lines.

+  EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocaleInStartUp("en"));
+  // Chinese in China with '-'.
+  EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocaleInStartUp("zh-CN"));
+  // Filipino : 3-letter code
+  EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocaleInStartUp("fil"));
+  // Russian
+  EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocaleInStartUp("ru"));
+  // Japanese that uses multiple scripts
+  EXPECT_EQ(LEFT_TO_RIGHT, GetTextDirectionForLocaleInStartUp("ja"));
+}
+
 TEST_F(RTLTest, UnadjustStringForLocaleDirection) {
   // These test strings are borrowed from WrapPathWithLTRFormatting
   const wchar_t* cases[] = {
     L"foo bar",
     L"foo \x05d0 bar",
     L"\x05d0 foo bar",
     L"!foo \x05d0 bar",
     L",\x05d0 foo bar",
     L"\x202a \x05d0 foo  bar",
     L"\x202d \x05d0 foo  bar",
@@ skipping 20 matching lines @@
       EXPECT_EQ(test_case, adjusted_string) << " for test case [" << test_case
                                             << "] with IsRTL() == " << IsRTL();
     }
   }
 
   EXPECT_EQ(was_rtl, IsRTL());
 }
 
 }  // namespace i18n
 }  // namespace base