Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: Source/core/html/shadow/SpinButtonElement.cpp

Issue 128133002: Update of change event for input type number (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review changes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/shadow/SpinButtonElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 // might change the element state and we might need to 104 // might change the element state and we might need to
105 // cancel the repeating timer by the state change. If we 105 // cancel the repeating timer by the state change. If we
106 // started the timer after doStepAction(), we would have no 106 // started the timer after doStepAction(), we would have no
107 // chance to cancel the timer. 107 // chance to cancel the timer.
108 startRepeatingTimer(); 108 startRepeatingTimer();
109 doStepAction(m_upDownState == Up ? 1 : -1); 109 doStepAction(m_upDownState == Up ? 1 : -1);
110 } 110 }
111 } 111 }
112 event->setDefaultHandled(); 112 event->setDefaultHandled();
113 } 113 }
114 } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->butt on() == LeftButton) 114 } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->butt on() == LeftButton) {
115 stopRepeatingTimer(); 115 releaseCapture();
116 else if (event->type() == EventTypeNames::mousemove) { 116 } else if (event->type() == EventTypeNames::mousemove) {
117 if (box->pixelSnappedBorderBoxRect().contains(local)) { 117 if (box->pixelSnappedBorderBoxRect().contains(local)) {
118 if (!m_capturing) { 118 if (!m_capturing) {
119 if (Frame* frame = document().frame()) { 119 if (Frame* frame = document().frame()) {
120 frame->eventHandler().setCapturingMouseEventsNode(this); 120 frame->eventHandler().setCapturingMouseEventsNode(this);
121 m_capturing = true; 121 m_capturing = true;
122 if (Page* page = document().page()) 122 if (Page* page = document().page())
123 page->chrome().registerPopupOpeningObserver(this); 123 page->chrome().registerPopupOpeningObserver(this);
124 } 124 }
125 } 125 }
126 UpDownState oldUpDownState = m_upDownState; 126 UpDownState oldUpDownState = m_upDownState;
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 void SpinButtonElement::releaseCapture() 191 void SpinButtonElement::releaseCapture()
192 { 192 {
193 stopRepeatingTimer(); 193 stopRepeatingTimer();
194 if (m_capturing) { 194 if (m_capturing) {
195 if (Frame* frame = document().frame()) { 195 if (Frame* frame = document().frame()) {
196 frame->eventHandler().setCapturingMouseEventsNode(0); 196 frame->eventHandler().setCapturingMouseEventsNode(0);
197 m_capturing = false; 197 m_capturing = false;
198 if (Page* page = document().page()) 198 if (Page* page = document().page())
199 page->chrome().unregisterPopupOpeningObserver(this); 199 page->chrome().unregisterPopupOpeningObserver(this);
200 } 200 }
201 if (m_spinButtonOwner)
202 m_spinButtonOwner->spinButtonDidReleaseMouseCapture();
201 } 203 }
202 } 204 }
203 205
204 bool SpinButtonElement::matchesReadOnlyPseudoClass() const 206 bool SpinButtonElement::matchesReadOnlyPseudoClass() const
205 { 207 {
206 return shadowHost()->matchesReadOnlyPseudoClass(); 208 return shadowHost()->matchesReadOnlyPseudoClass();
207 } 209 }
208 210
209 bool SpinButtonElement::matchesReadWritePseudoClass() const 211 bool SpinButtonElement::matchesReadWritePseudoClass() const
210 { 212 {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 m_upDownState = Indeterminate; 251 m_upDownState = Indeterminate;
250 HTMLDivElement::setHovered(flag); 252 HTMLDivElement::setHovered(flag);
251 } 253 }
252 254
253 bool SpinButtonElement::shouldRespondToMouseEvents() 255 bool SpinButtonElement::shouldRespondToMouseEvents()
254 { 256 {
255 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents(); 257 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents();
256 } 258 }
257 259
258 } 260 }
OLDNEW
« no previous file with comments | « Source/core/html/shadow/SpinButtonElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698