LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html - Issue 128133002: Update of change event for input type number

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html

Issue 128133002: Update of change event for input type number (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added callback function in SpinButtonOwner and added new tests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE>

	2 <html>

	3 <body>

	4 <script src="../../../resources/js-test.js"></script>

	5 <input type="number" id="num1" onchange="handleChangeEvent(this);" oninput="hand leInputEvent(this);">

	6 <script>

	7 var changeEventCounter = 0;

	8 var inputEventCounter = 0;

	9

	10 function handleChangeEvent(element){

	11 ++changeEventCounter;
	tkent 2014/01/17 02:19:20 We usually use four-space indentation in JavaScrip We usually use four-space indentation in JavaScript code.
	12 }

	13

	14 function handleInputEvent(element){

	15 ++inputEventCounter;

	16 }

	17

	18 var numberInput1= document.getElementById('num1');

	19 numberInput1.focus();

	20 eventSender.mouseMoveTo(0, 0);

	21 eventSender.mouseMoveTo(numberInput1.offsetLeft + numberInput1.offsetWidth - 10, numberInput1.offsetTop + numberInput1.offsetHeight / 4);

	22 eventSender.mouseDown();

	23 debug('Only input event occurs on mouse down');

	24 shouldBe('inputEventCounter', '1');

	25 shouldBe('changeEventCounter', '0');
	tkent 2014/01/17 02:19:20 Good. This check demonstrates that change events Good. This check demonstrates that change events are not dispatched with 'input' events.
	26 debug('Only change event occurs on mouse up');

	27 eventSender.mouseUp();

	28 shouldBe('inputEventCounter', '1');

	29 shouldBe('changeEventCounter', '1');

	30

	31 </script>

	32 </body>

	33 </html>

OLD	NEW