Update of change event for input type number

Source/core/html/shadow/SpinButtonElement.cpp

 /*
  * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/html/shadow/SpinButtonElement.h"
 
 #include "HTMLNames.h"
 #include "core/events/MouseEvent.h"
 #include "core/events/ThreadLocalEventNames.h"
 #include "core/events/WheelEvent.h"
+#include "core/html/HTMLInputElement.h"
 #include "core/html/shadow/ShadowElementNames.h"
 #include "core/page/Chrome.h"
 #include "core/page/EventHandler.h"
 #include "core/frame/Frame.h"
 #include "core/page/Page.h"
 #include "core/rendering/RenderBox.h"
 #include "platform/scroll/ScrollbarTheme.h"
 
 namespace WebCore {
 
@@ skipping 60 matching lines @@
                     // might change the element state and we might need to
                     // cancel the repeating timer by the state change. If we
                     // started the timer after doStepAction(), we would have no
                     // chance to cancel the timer.
                     startRepeatingTimer();
                     doStepAction(m_upDownState == Up ? 1 : -1);
                 }
             }
             event->setDefaultHandled();
         }
-    } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->button() == LeftButton)
-        stopRepeatingTimer();
-    else if (event->type() == EventTypeNames::mousemove) {
+    } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->button() == LeftButton) {
+        releaseCapture();
+    } else if (event->type() == EventTypeNames::mousemove) {
         if (box->pixelSnappedBorderBoxRect().contains(local)) {
             if (!m_capturing) {
                 if (Frame* frame = document().frame()) {
                     frame->eventHandler().setCapturingMouseEventsNode(this);
                     m_capturing = true;
                     if (Page* page = document().page())
                         page->chrome().registerPopupOpeningObserver(this);
                 }
             }
             UpDownState oldUpDownState = m_upDownState;
@@ skipping 64 matching lines @@
 void SpinButtonElement::releaseCapture()
 {
     stopRepeatingTimer();
     if (m_capturing) {
         if (Frame* frame = document().frame()) {
             frame->eventHandler().setCapturingMouseEventsNode(0);
             m_capturing = false;
             if (Page* page = document().page())
                 page->chrome().unregisterPopupOpeningObserver(this);
         }
+        HTMLInputElement* input = toHTMLInputElement(shadowHost());

[tkent, 2014/01/16 06:05:19]

Please do not add dependency to HTMLInputElement.
We should add new callback to SpinButtonOwner class, and owners should implement
it.

[Habib Virji, 2014/01/16 09:49:18]

OK will update code accordingly and send a new patch. 

+        input->dispatchFormControlChangeEvent();
     }
 }
 
 bool SpinButtonElement::matchesReadOnlyPseudoClass() const
 {
     return shadowHost()->matchesReadOnlyPseudoClass();
 }
 
 bool SpinButtonElement::matchesReadWritePseudoClass() const
 {
@@ skipping 38 matching lines @@
         m_upDownState = Indeterminate;
     HTMLDivElement::setHovered(flag);
 }
 
 bool SpinButtonElement::shouldRespondToMouseEvents()
 {
     return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMouseEvents();
 }
 
 }