Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: Source/core/html/shadow/SpinButtonElement.cpp

Issue 128133002: Update of change event for input type number (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/html/shadow/SpinButtonElement.h" 28 #include "core/html/shadow/SpinButtonElement.h"
29 29
30 #include "HTMLNames.h" 30 #include "HTMLNames.h"
31 #include "core/events/MouseEvent.h" 31 #include "core/events/MouseEvent.h"
32 #include "core/events/ThreadLocalEventNames.h" 32 #include "core/events/ThreadLocalEventNames.h"
33 #include "core/events/WheelEvent.h" 33 #include "core/events/WheelEvent.h"
34 #include "core/html/HTMLInputElement.h"
34 #include "core/html/shadow/ShadowElementNames.h" 35 #include "core/html/shadow/ShadowElementNames.h"
35 #include "core/page/Chrome.h" 36 #include "core/page/Chrome.h"
36 #include "core/page/EventHandler.h" 37 #include "core/page/EventHandler.h"
37 #include "core/frame/Frame.h" 38 #include "core/frame/Frame.h"
38 #include "core/page/Page.h" 39 #include "core/page/Page.h"
39 #include "core/rendering/RenderBox.h" 40 #include "core/rendering/RenderBox.h"
40 #include "platform/scroll/ScrollbarTheme.h" 41 #include "platform/scroll/ScrollbarTheme.h"
41 42
42 namespace WebCore { 43 namespace WebCore {
43 44
(...skipping 18 matching lines...) Expand all
62 } 63 }
63 64
64 void SpinButtonElement::detach(const AttachContext& context) 65 void SpinButtonElement::detach(const AttachContext& context)
65 { 66 {
66 releaseCapture(); 67 releaseCapture();
67 HTMLDivElement::detach(context); 68 HTMLDivElement::detach(context);
68 } 69 }
69 70
70 void SpinButtonElement::defaultEventHandler(Event* event) 71 void SpinButtonElement::defaultEventHandler(Event* event)
71 { 72 {
73 if (event->isKeyboardEvent()) {
74 HTMLInputElement* input = toHTMLInputElement(shadowHost());
75 input->dispatchFormControlChangeEvent();
76 }
77
72 if (!event->isMouseEvent()) { 78 if (!event->isMouseEvent()) {
73 if (!event->defaultHandled()) 79 if (!event->defaultHandled())
74 HTMLDivElement::defaultEventHandler(event); 80 HTMLDivElement::defaultEventHandler(event);
75 return; 81 return;
76 } 82 }
77 83
78 RenderBox* box = renderBox(); 84 RenderBox* box = renderBox();
79 if (!box) { 85 if (!box) {
80 if (!event->defaultHandled()) 86 if (!event->defaultHandled())
81 HTMLDivElement::defaultEventHandler(event); 87 HTMLDivElement::defaultEventHandler(event);
(...skipping 22 matching lines...) Expand all
104 // might change the element state and we might need to 110 // might change the element state and we might need to
105 // cancel the repeating timer by the state change. If we 111 // cancel the repeating timer by the state change. If we
106 // started the timer after doStepAction(), we would have no 112 // started the timer after doStepAction(), we would have no
107 // chance to cancel the timer. 113 // chance to cancel the timer.
108 startRepeatingTimer(); 114 startRepeatingTimer();
109 doStepAction(m_upDownState == Up ? 1 : -1); 115 doStepAction(m_upDownState == Up ? 1 : -1);
110 } 116 }
111 } 117 }
112 event->setDefaultHandled(); 118 event->setDefaultHandled();
113 } 119 }
114 } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->butt on() == LeftButton) 120 } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->butt on() == LeftButton) {
115 stopRepeatingTimer(); 121 stopRepeatingTimer();
116 else if (event->type() == EventTypeNames::mousemove) { 122 HTMLInputElement* input = toHTMLInputElement(shadowHost());
123 input->dispatchFormControlChangeEvent();
124 } else if (event->type() == EventTypeNames::mousemove) {
117 if (box->pixelSnappedBorderBoxRect().contains(local)) { 125 if (box->pixelSnappedBorderBoxRect().contains(local)) {
118 if (!m_capturing) { 126 if (!m_capturing) {
119 if (Frame* frame = document().frame()) { 127 if (Frame* frame = document().frame()) {
120 frame->eventHandler().setCapturingMouseEventsNode(this); 128 frame->eventHandler().setCapturingMouseEventsNode(this);
121 m_capturing = true; 129 m_capturing = true;
122 if (Page* page = document().page()) 130 if (Page* page = document().page())
123 page->chrome().registerPopupOpeningObserver(this); 131 page->chrome().registerPopupOpeningObserver(this);
124 } 132 }
125 } 133 }
126 UpDownState oldUpDownState = m_upDownState; 134 UpDownState oldUpDownState = m_upDownState;
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 m_upDownState = Indeterminate; 257 m_upDownState = Indeterminate;
250 HTMLDivElement::setHovered(flag); 258 HTMLDivElement::setHovered(flag);
251 } 259 }
252 260
253 bool SpinButtonElement::shouldRespondToMouseEvents() 261 bool SpinButtonElement::shouldRespondToMouseEvents()
254 { 262 {
255 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents(); 263 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents();
256 } 264 }
257 265
258 } 266 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698