Remove items on long press in keyboard accessory.

chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
index 85b48904fbd3aebde4c89963e721c7e8fefa4a78..8dc6c3408f3201825b9218b4d60ce5c6556bdcb1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
@@ -4,12 +4,17 @@
 
 package org.chromium.chrome.browser.autofill;
 
+import android.content.Context;
+import android.content.DialogInterface;
+import android.support.v7.app.AlertDialog;
+
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
+import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ResourceId;
 import org.chromium.ui.DropdownItem;
+import org.chromium.ui.autofill.AutofillDelegate;
 import org.chromium.ui.autofill.AutofillKeyboardAccessory;
-import org.chromium.ui.autofill.AutofillKeyboardAccessory.AutofillKeyboardAccessoryDelegate;
 import org.chromium.ui.autofill.AutofillSuggestion;
 import org.chromium.ui.base.WindowAndroid;
 
@@ -19,9 +24,11 @@ import org.chromium.ui.base.WindowAndroid;
 * --enable-autofill-keyboard-accessory-view is passed on the command line.
 */
 @JNINamespace("autofill")
-public class AutofillKeyboardAccessoryBridge implements AutofillKeyboardAccessoryDelegate {
+public class AutofillKeyboardAccessoryBridge
+        implements AutofillDelegate, DialogInterface.OnClickListener {
     private long mNativeAutofillKeyboardAccessory;
     private AutofillKeyboardAccessory mAccessoryView;
+    private Context mContext;
 
     private AutofillKeyboardAccessoryBridge() {
     }
@@ -43,6 +50,19 @@ public class AutofillKeyboardAccessoryBridge implements AutofillKeyboardAccessor
         nativeSuggestionSelected(mNativeAutofillKeyboardAccessory, listIndex);
     }
 
+    @Override
+    public void deleteSuggestion(int listIndex) {
+        if (mNativeAutofillKeyboardAccessory == 0) return;
+        nativeDeletionRequested(mNativeAutofillKeyboardAccessory, listIndex);
+    }
+
+    @Override
+    public void onClick(DialogInterface dialog, int which) {
+        assert which == DialogInterface.BUTTON_POSITIVE;
+        if (mNativeAutofillKeyboardAccessory == 0) return;
+        nativeDeletionConfirmed(mNativeAutofillKeyboardAccessory);
+    }
+
     /**
      * Initializes this object.
      * This function should be called at most one time.
@@ -59,6 +79,7 @@ public class AutofillKeyboardAccessoryBridge implements AutofillKeyboardAccessor
 
         mNativeAutofillKeyboardAccessory = nativeAutofillKeyboardAccessory;
         mAccessoryView = new AutofillKeyboardAccessory(windowAndroid, this);
+        mContext = windowAndroid.getActivity().get();

[Yaron, 2015/08/14 18:13:42]

You're potentially leaking the activity.  Is this object guaranteed to be
deleted if the activity gets stopped?
Sorry, I'm not familiar with this code to know the owner/lifetime.

[please use gerrit instead, 2015/08/14 20:23:31]

Newton, do you know the answer to this question?

I am not familiar with how Chrome on Android handles its activity being stopped.
This object is owned by

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

...in case if that's helpful.

     }
 
     /**
@@ -91,6 +112,17 @@ public class AutofillKeyboardAccessoryBridge implements AutofillKeyboardAccessor
     // eventually disappear).
 
     @CalledByNative
+    private void confirmDeletion(String title, String body) {
+        new AlertDialog.Builder(mContext, R.style.AlertDialogTheme)
+                .setTitle(title)
+                .setMessage(body)
+                .setNegativeButton(R.string.cancel, null)
+                .setPositiveButton(R.string.ok, this)
+                .create()
+                .show();
+    }
+
+    @CalledByNative
     private static AutofillSuggestion[] createAutofillSuggestionArray(int size) {
         return new AutofillSuggestion[size];
     }
@@ -114,12 +146,15 @@ public class AutofillKeyboardAccessoryBridge implements AutofillKeyboardAccessor
      */
     @CalledByNative
     private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,
-            String label, String sublabel, int iconId, int suggestionId) {
+            String label, String sublabel, int iconId, int suggestionId, boolean deletable) {
         int drawableId = iconId == 0 ? DropdownItem.NO_ICON : ResourceId.mapToDrawableId(iconId);
-        array[index] = new AutofillSuggestion(label, sublabel, drawableId, suggestionId, false);
+        array[index] = new AutofillSuggestion(label, sublabel, drawableId, suggestionId, deletable);
     }
 
     private native void nativeViewDismissed(long nativeAutofillKeyboardAccessoryView);
     private native void nativeSuggestionSelected(
             long nativeAutofillKeyboardAccessoryView, int listIndex);
+    private native void nativeDeletionRequested(
+            long nativeAutofillKeyboardAccessoryView, int listIndex);
+    private native void nativeDeletionConfirmed(long nativeAutofillKeyboardAccessoryView);
 }