chrome/common/service_process_util_mac.mm - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_mac.mm

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/service_process_util_mac.mm

diff --git a/chrome/common/service_process_util_mac.mm b/chrome/common/service_process_util_mac.mm

index 5a229eb017d404b02aa1c41205f109da0d5da9f3..517dcdf9baf82d3b830dfc7dad8dc9e3f130e31e 100644

--- a/chrome/common/service_process_util_mac.mm

+++ b/chrome/common/service_process_util_mac.mm

@@ -203,12 +203,12 @@ bool CheckServiceProcessReady() {

if (!GetServiceProcessData(&version, &pid)) {

return false;

}

- Version service_version(version);

+ base::Version service_version(version);

bool ready = true;

if (!service_version.IsValid()) {

ready = false;

} else {

- Version running_version(version_info::GetVersionNumber());

+ base::Version running_version(version_info::GetVersionNumber());

if (!running_version.IsValid()) {

// Our own version is invalid. This is an error case. Pretend that we

// are out of date.

« no previous file with comments | « chrome/common/service_process_util.cc ('k') | chrome/installer/setup/install.h » ('j') | no next file with comments »