Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2781)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/swiftshader_component_installer.cc ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/enumerate_modules_model_win.cc
diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc
index a940c2eeb1bfcff301caf188e679ac20aad9c9d3..ca6666f598759ff2aa01a053b675421d30664d39 100644
--- a/chrome/browser/enumerate_modules_model_win.cc
+++ b/chrome/browser/enumerate_modules_model_win.cc
@@ -412,9 +412,9 @@ ModuleEnumerator::ModuleStatus ModuleEnumerator::Match(
location_hash == blacklisted.location)) {
// We have a name match against the blacklist (and possibly location match
// also), so check version.
- Version module_version(base::UTF16ToASCII(module.version));
- Version version_min(blacklisted.version_from);
- Version version_max(blacklisted.version_to);
+ base::Version module_version(base::UTF16ToASCII(module.version));
+ base::Version version_min(blacklisted.version_from);
+ base::Version version_max(blacklisted.version_to);
bool version_ok = !version_min.IsValid() && !version_max.IsValid();
if (!version_ok) {
bool too_low = version_min.IsValid() &&
« no previous file with comments | « chrome/browser/component_updater/swiftshader_component_installer.cc ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698