base/version.h - Issue 1281313003: base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/version.h

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ninja -C out/Debug all Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/version.h

diff --git a/base/version.h b/base/version.h

index 814acaa2b4ed83f29b5aafe47b6c48b649ec7ed0..7ce18dc10f8f00c857261660b3aa366ddf83c053 100644

--- a/base/version.h

+++ b/base/version.h

@@ -10,7 +10,6 @@

#include <vector>

#include "base/base_export.h"

-#include "base/basictypes.h"

namespace base {

@@ -66,8 +65,4 @@ class BASE_EXPORT Version {

} // namespace base

-// TODO(xhwang) remove this when all users are updated to explicitly use the

-// namespace

-using base::Version;

#endif // BASE_VERSION_H_

« no previous file with comments | « no previous file | base/version_unittest.cc » ('j') | chrome/browser/plugins/plugin_metadata.cc » ('J')