Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: base/version.h

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/version_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_VERSION_H_ 5 #ifndef BASE_VERSION_H_
6 #define BASE_VERSION_H_ 6 #define BASE_VERSION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/base_export.h" 12 #include "base/base_export.h"
13 #include "base/basictypes.h"
14 13
15 namespace base { 14 namespace base {
16 15
17 // Version represents a dotted version number, like "1.2.3.4", supporting 16 // Version represents a dotted version number, like "1.2.3.4", supporting
18 // parsing and comparison. 17 // parsing and comparison.
19 class BASE_EXPORT Version { 18 class BASE_EXPORT Version {
20 public: 19 public:
21 // The only thing you can legally do to a default constructed 20 // The only thing you can legally do to a default constructed
22 // Version object is assign to it. 21 // Version object is assign to it.
23 Version(); 22 Version();
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 const std::string GetString() const; 58 const std::string GetString() const;
60 59
61 const std::vector<uint32_t>& components() const { return components_; } 60 const std::vector<uint32_t>& components() const { return components_; }
62 61
63 private: 62 private:
64 std::vector<uint32_t> components_; 63 std::vector<uint32_t> components_;
65 }; 64 };
66 65
67 } // namespace base 66 } // namespace base
68 67
69 // TODO(xhwang) remove this when all users are updated to explicitly use the
70 // namespace
71 using base::Version;
72
73 #endif // BASE_VERSION_H_ 68 #endif // BASE_VERSION_H_
OLDNEW
« no previous file with comments | « no previous file | base/version_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698