Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 12813013: [Telemetry] Cause web server to keep resources in memory and thread requests. (Closed)

Created:
7 years, 9 months ago by tonyg
Modified:
7 years, 9 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Cause web server to keep resources in memory and thread requests. My hope is that this will solve the noise problem on the perf bots. The theory being that the disk accesses in a single-threaded HTTP server could cause significant hiccups in the page loads. To accomplish this, we extend SimpleHTTPServer and override the key methods to serve from an in-memory cache rather than by reading from disk for each URL. Unfortunately, the page_cycler data directory is >300M, so to avoid reading in the whole thing, the page_cycler page_sets now specify the directories that they actually need. BUG=196411 TEST=Ran various benchmarks and unittests NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189958

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address nduca comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -84 lines) Patch
M tools/perf/page_sets/page_cycler/alexa_us.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/bloat.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/database/delete-transactions.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/database/insert-transactions.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/database/pseudo-random-transactions.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/database/select-readtransactions.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/database/select-readtransactions-read-results.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/database/select-transactions.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/database/update-transactions.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/dhtml.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/dom.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/intl1.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/intl2.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/morejs.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/morejsnp.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/moz.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/moz2.json View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 1 chunk +5 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/chrome/inspector_memory_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/chrome/inspector_page_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/inspector_timeline_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/chrome/tracing_backend_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
A tools/telemetry/telemetry/core/memory_cache_http_server.py View 1 1 chunk +83 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/temporary_http_server.py View 3 chunks +17 lines, -24 lines 0 comments Download
M tools/telemetry/telemetry/core/temporary_http_server_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/click_element_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/wait_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page.py View 2 chunks +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
ptal, this CL isn't actually as big as it looks. I just had to update ...
7 years, 9 months ago (2013-03-22 23:41:15 UTC) #1
nduca
https://codereview.chromium.org/12813013/diff/1/tools/telemetry/telemetry/core/browser.py File tools/telemetry/telemetry/core/browser.py (right): https://codereview.chromium.org/12813013/diff/1/tools/telemetry/telemetry/core/browser.py#newcode175 tools/telemetry/telemetry/core/browser.py:175: def SetHTTPServerDirectory(self, paths): should we tweak this name to ...
7 years, 9 months ago (2013-03-23 00:09:06 UTC) #2
nduca
(lgtm)
7 years, 9 months ago (2013-03-23 00:09:17 UTC) #3
tonyg
https://codereview.chromium.org/12813013/diff/1/tools/telemetry/telemetry/core/browser.py File tools/telemetry/telemetry/core/browser.py (right): https://codereview.chromium.org/12813013/diff/1/tools/telemetry/telemetry/core/browser.py#newcode175 tools/telemetry/telemetry/core/browser.py:175: def SetHTTPServerDirectory(self, paths): On 2013/03/23 00:09:06, nduca wrote: > ...
7 years, 9 months ago (2013-03-23 00:27:21 UTC) #4
tonyg
7 years, 9 months ago (2013-03-23 00:29:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r189958 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698