Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281273004: Move CrossThreadHolder to CrossThreadHolder.h (Closed)

Created:
5 years, 4 months ago by hiroshige
Modified:
5 years, 4 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move CrossThreadHolder to CrossThreadHolder.h BUG=502361 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200466

Patch Set 1 #

Total comments: 2

Patch Set 2 : final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -161 lines) Patch
A Source/modules/fetch/CrossThreadHolder.h View 1 1 chunk +177 lines, -0 lines 0 comments Download
M Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 2 chunks +1 line, -161 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281273004/1
5 years, 4 months ago (2015-08-11 08:49:24 UTC) #2
hiroshige
PTAL.
5 years, 4 months ago (2015-08-11 10:22:35 UTC) #5
yhirano
lgtm https://codereview.chromium.org/1281273004/diff/1/Source/modules/fetch/CrossThreadHolder.h File Source/modules/fetch/CrossThreadHolder.h (right): https://codereview.chromium.org/1281273004/diff/1/Source/modules/fetch/CrossThreadHolder.h#newcode31 Source/modules/fetch/CrossThreadHolder.h:31: class CrossThreadHolder { +final
5 years, 4 months ago (2015-08-12 13:50:12 UTC) #6
hiroshige
https://codereview.chromium.org/1281273004/diff/1/Source/modules/fetch/CrossThreadHolder.h File Source/modules/fetch/CrossThreadHolder.h (right): https://codereview.chromium.org/1281273004/diff/1/Source/modules/fetch/CrossThreadHolder.h#newcode31 Source/modules/fetch/CrossThreadHolder.h:31: class CrossThreadHolder { On 2015/08/12 13:50:12, yhirano wrote: > ...
5 years, 4 months ago (2015-08-13 04:51:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281273004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281273004/20001
5 years, 4 months ago (2015-08-13 04:52:10 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 06:07:09 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200466

Powered by Google App Engine
This is Rietveld 408576698