Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1281273002: Update fancy_urllib to work with python-2.7.10 (Closed)

Created:
5 years, 4 months ago by Peter Mayo
Modified:
5 years, 4 months ago
Reviewers:
andreyu, vapier, agable, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Update fancy_urllib to work with python-2.7.10 This issue is cloned from https://codereview.chromium.org/1273083004/ for andreyu BUG=chromium:517460 R=vapier@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -56 lines) Patch
M third_party/fancy_urllib/README View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/fancy_urllib/__init__.py View 11 chunks +114 lines, -52 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281273002/1
5 years, 4 months ago (2015-08-10 16:31:06 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-10 16:31:07 UTC) #4
Peter Mayo
PTAL, putting this forward for andreyu.
5 years, 4 months ago (2015-08-10 19:36:51 UTC) #6
andreyu
lgtm
5 years, 4 months ago (2015-08-10 19:51:10 UTC) #7
Peter Mayo
including agable for depot_tools second.
5 years, 4 months ago (2015-08-12 22:13:39 UTC) #9
agable
fancy_urllib appears to be in depot_tools as a dependency of gsutil. Are we sure gsutil ...
5 years, 4 months ago (2015-08-12 22:24:23 UTC) #10
andreyu
On 2015/08/12 22:24:23, agable wrote: > fancy_urllib appears to be in depot_tools as a dependency ...
5 years, 4 months ago (2015-08-12 22:34:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281273002/1
5 years, 4 months ago (2015-08-12 22:59:17 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 23:01:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296285

Powered by Google App Engine
This is Rietveld 408576698