Change webcamPrivate.set/get/reset to async APIs.

extensions/browser/api/webcam_private/webcam_private_api.h

Index: extensions/browser/api/webcam_private/webcam_private_api.h
diff --git a/extensions/browser/api/webcam_private/webcam_private_api.h b/extensions/browser/api/webcam_private/webcam_private_api.h
index ec2cf93fed783d494c273c318494072c030bc098..415d5ea2dd78171bfd00a7094f4d4d353104ad98 100644
--- a/extensions/browser/api/webcam_private/webcam_private_api.h
+++ b/extensions/browser/api/webcam_private/webcam_private_api.h
@@ -91,8 +91,6 @@ class WebcamPrivateOpenSerialWebcamFunction : public AsyncExtensionFunction {
 
  protected:
   ~WebcamPrivateOpenSerialWebcamFunction() override;
-
-  // AsyncExtensionFunction:
   bool RunAsync() override;
 
  private:
@@ -109,50 +107,54 @@ class WebcamPrivateCloseWebcamFunction : public AsyncExtensionFunction {
 
  protected:
   ~WebcamPrivateCloseWebcamFunction() override;
-
-  // AsyncApiFunction:

[Zachary Kuznia, 2015/08/19 20:49:44]

Why did you remove these comments?

[xdai1, 2015/08/21 22:57:03]

It seems a little redundant? I noticed that several classes in this file don't
have this kind of comments while other do. Besides, if we do want to add "//
AsyncApiFunction" comment here, maybe we should move it before
"~WebcamPrivateCloseWebcamFunction()" since it's also an override function?

   bool RunAsync() override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WebcamPrivateCloseWebcamFunction);
 };
 
-class WebcamPrivateSetFunction : public SyncExtensionFunction {
+class WebcamPrivateSetFunction : public AsyncExtensionFunction {
  public:
   WebcamPrivateSetFunction();
   DECLARE_EXTENSION_FUNCTION("webcamPrivate.set", WEBCAMPRIVATE_SET);
 
  protected:
   ~WebcamPrivateSetFunction() override;
-  bool RunSync() override;
+  bool RunAsync() override;
 
  private:
+  void OnSetWebcamParameters(bool success);
+
   DISALLOW_COPY_AND_ASSIGN(WebcamPrivateSetFunction);
 };
 
-class WebcamPrivateGetFunction : public SyncExtensionFunction {
+class WebcamPrivateGetFunction : public AsyncExtensionFunction {
  public:
   WebcamPrivateGetFunction();
   DECLARE_EXTENSION_FUNCTION("webcamPrivate.get", WEBCAMPRIVATE_GET);
 
  protected:
   ~WebcamPrivateGetFunction() override;
-  bool RunSync() override;
+  bool RunAsync() override;
 
  private:
+  void OnGetWebcamParameters(bool success, int value);
+
   DISALLOW_COPY_AND_ASSIGN(WebcamPrivateGetFunction);
 };
 
-class WebcamPrivateResetFunction : public SyncExtensionFunction {
+class WebcamPrivateResetFunction : public AsyncExtensionFunction {
  public:
   WebcamPrivateResetFunction();
   DECLARE_EXTENSION_FUNCTION("webcamPrivate.reset", WEBCAMPRIVATE_RESET);
 
  protected:
   ~WebcamPrivateResetFunction() override;
-  bool RunSync() override;
+  bool RunAsync() override;
 
  private:
+  void OnResetWebcam(bool success);
+
   DISALLOW_COPY_AND_ASSIGN(WebcamPrivateResetFunction);
 };