Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: extensions/browser/api/webcam_private/v4l2_webcam.h

Issue 1281263003: Change webcamPrivate.set/get/reset to async APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Zach's comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/webcam_private/v4l2_webcam.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/webcam_private/v4l2_webcam.h
diff --git a/extensions/browser/api/webcam_private/v4l2_webcam.h b/extensions/browser/api/webcam_private/v4l2_webcam.h
index 388aed432bac12fe4566ae2adb414b93c1466c13..4f248c1c30f040646d710f8c66a394f61faa5d42 100644
--- a/extensions/browser/api/webcam_private/v4l2_webcam.h
+++ b/extensions/browser/api/webcam_private/v4l2_webcam.h
@@ -23,15 +23,20 @@ class V4L2Webcam : public Webcam {
bool GetWebcamParameter(int fd, uint32_t control_id, int* value);
// Webcam:
- void Reset(bool pan, bool tilt, bool zoom) override;
- bool GetPan(int* value) override;
- bool GetTilt(int* value) override;
- bool GetZoom(int* value) override;
- bool SetPan(int value) override;
- bool SetTilt(int value) override;
- bool SetZoom(int value) override;
- bool SetPanDirection(PanDirection direction) override;
- bool SetTiltDirection(TiltDirection direction) override;
+ void GetPan(const GetPTZCompleteCallback& callback) override;
+ void GetTilt(const GetPTZCompleteCallback& callback) override;
+ void GetZoom(const GetPTZCompleteCallback& callback) override;
+ void SetPan(int value, const SetPTZCompleteCallback& callback) override;
+ void SetTilt(int value, const SetPTZCompleteCallback& callback) override;
+ void SetZoom(int value, const SetPTZCompleteCallback& callback) override;
+ void SetPanDirection(PanDirection direction,
+ const SetPTZCompleteCallback& callback) override;
+ void SetTiltDirection(TiltDirection direction,
+ const SetPTZCompleteCallback& callback) override;
+ void Reset(bool pan,
+ bool tilt,
+ bool zoom,
+ const SetPTZCompleteCallback& callback) override;
const std::string device_id_;
base::ScopedFD fd_;
« no previous file with comments | « no previous file | extensions/browser/api/webcam_private/v4l2_webcam.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698