Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1281233003: [heap] Avoid overzealous inclusion of heap internal headers. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Avoid overzealous inclusion of heap internal headers. This is a first step towards constraining down the heap interface to just the heap.h file. Note that many includes still leak through that file to the global "src" directory, but there now is a single place controlling which declarations leak that way. Especially inclusion of inline header files within "heap" has been limited drastically. R=hpayer@chromium.org,mlippautz@chromium.org Committed: https://crrev.com/65c8ecc65ec8a6a95b7a1fdb96499dd1fbcd21aa Cr-Commit-Position: refs/heads/master@{#30092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M src/DEPS View 2 chunks +12 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-10 13:38:19 UTC) #1
Hannes Payer (out of office)
This is great! LGTM!
5 years, 4 months ago (2015-08-10 16:04:13 UTC) #2
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-10 16:29:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281233003/1
5 years, 4 months ago (2015-08-10 16:30:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 16:32:15 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 16:32:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65c8ecc65ec8a6a95b7a1fdb96499dd1fbcd21aa
Cr-Commit-Position: refs/heads/master@{#30092}

Powered by Google App Engine
This is Rietveld 408576698