runtime/vm/flow_graph_compiler.cc - Issue 12812026: Fix crash caused by eliminating goto-s in unoptimized code. Added asserts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 12812026: Fix crash caused by eliminating goto-s in unoptimized code. Added asserts (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

===================================================================

--- runtime/vm/flow_graph_compiler.cc (revision 20337)

+++ runtime/vm/flow_graph_compiler.cc (working copy)

@@ -236,7 +236,10 @@

for (intptr_t i = block_order().length() - 1; i >= 1; --i) {

BlockEntryInstr* block = block_order()[i];

- CompactBlock(block);

+ // Unoptimized code must emit all possible deoptimization points.

+ if (is_optimizing()) {

+ CompactBlock(block);

+ }

if (!WasCompacted(block)) {

BlockInfo* block_info = block_info_[block->postorder_number()];

« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | no next file » | no next file with comments »