dart:io | Add Link.targetSync on all platforms.

runtime/bin/file_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/file.h"
 
 #include <fcntl.h>  // NOLINT
@@ skipping 261 matching lines @@
   const wchar_t* system_name = StringUtils::Utf8ToWide(name);
   int stat_status = _wstat(system_name, &st);
   free(const_cast<wchar_t*>(system_name));
   if (stat_status == 0) {
     return st.st_size;
   }
   return -1;
 }
 
 
+char* File::LinkTarget(const char* pathname) {
+  const wchar_t* name = StringUtils::Utf8ToWide(pathname);
+  HANDLE dir_handle = CreateFileW(
+      name,
+      GENERIC_READ,
+      FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
+      NULL,
+      OPEN_EXISTING,
+      FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_OPEN_REPARSE_POINT,
+      NULL);
+  free(const_cast<wchar_t*>(name));
+  if (dir_handle == INVALID_HANDLE_VALUE) {
+    return NULL;
+  }
+
+  int reparse_data_buffer_size =
+      sizeof REPARSE_DATA_BUFFER + 2 * (MAX_PATH + 1) * sizeof WCHAR;
+  REPARSE_DATA_BUFFER* reparse_data_buffer =
+      static_cast<REPARSE_DATA_BUFFER*>(calloc(reparse_data_buffer_size, 1));
+  DWORD received_bytes;
+  int result = DeviceIoControl(
+      dir_handle,
+      FSCTL_GET_REPARSE_POINT,
+      NULL,
+      0,
+      reparse_data_buffer,
+      reparse_data_buffer_size,
+      &received_bytes,
+      NULL);
+  if (CloseHandle(dir_handle) == 0) return NULL;

[Søren Gjesse, 2013/03/18 12:28:03]

Here it seems like we are clearing the last error before returning NULL. Don't
we need a GetLastError/SetLastError here?

[Bill Hesse, 2013/03/18 16:13:27]

Yes.  Fixed.

+  if (result == 0) return NULL;
+  if (reparse_data_buffer->ReparseTag != IO_REPARSE_TAG_MOUNT_POINT) {

[Søren Gjesse, 2013/03/18 12:28:03]

Here GetLastError will return NOERROR, so we get an OSError with an error code
of 0.

[Bill Hesse, 2013/03/18 16:13:27]

Now we are returning Not a Reparse Point.  

+    return NULL;
+  }
+  wchar_t* target = reparse_data_buffer->MountPointReparseBuffer.PathBuffer +
+      reparse_data_buffer->MountPointReparseBuffer.SubstituteNameOffset;
+  size_t target_length =
+      reparse_data_buffer->MountPointReparseBuffer.SubstituteNameLength;
+  // Remove "\??\" from beginning of target.
+  if (target_length <= 4 || wcsncmp(L"\\??\\", target, 4) != 0) return NULL;

[Søren Gjesse, 2013/03/18 12:28:03]

Ditto.

[Bill Hesse, 2013/03/18 16:13:27]

Changed.  Now, we just skip removing \??\ if it isn't there.  This is the right
behavior for symbolic links.

+  int utf8_length = WideCharToMultiByte(CP_UTF8,

[Søren Gjesse, 2013/03/18 12:28:03]

Indentation.

+                                0,
+                                target + 4,
+                                target_length - 4,
+                                NULL,
+                                0,
+                                NULL,
+                                NULL);

[Søren Gjesse, 2013/03/18 12:28:03]

Can this call fail?

[Bill Hesse, 2013/03/18 16:13:27]

If it fails, it returns 0, and the next call to it will fail as well.

+  char* utf8_target = reinterpret_cast<char*>(malloc(utf8_length + 1));
+  if (0 == WideCharToMultiByte(CP_UTF8,
+                               0,
+                               target + 4,
+                               target_length - 4,
+                               utf8_target,
+                               utf8_length,
+                               NULL,
+                               NULL)) {
+    free(reparse_data_buffer);
+    free(utf8_target);

[Søren Gjesse, 2013/03/18 12:28:03]

Set an error code?

[Bill Hesse, 2013/03/18 16:13:27]

Done.

+    return NULL;
+  }
+  utf8_target[utf8_length] = '\0';
+  free(reparse_data_buffer);
+  return utf8_target;
+}
+
+
 time_t File::LastModified(const char* name) {
   struct _stat st;
   const wchar_t* system_name = StringUtils::Utf8ToWide(name);
   int stat_status = _wstat(system_name, &st);
   free(const_cast<wchar_t*>(system_name));
   if (stat_status == 0) {
     return st.st_mtime;
   }
   return -1;
 }
@@ skipping 118 matching lines @@
       }
     }
   } else if ((attributes & FILE_ATTRIBUTE_DIRECTORY) != 0) {
     return File::kIsDirectory;
   } else {
     return File::kIsFile;
   }
 }
 
 #endif  // defined(TARGET_OS_WINDOWS)