Issue 128113002: Removed v8::AssertNoGCScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128113002: Removed v8::AssertNoGCScope. (Closed)

Created:
6 years, 11 months ago by Sven Panne

Modified:
6 years, 11 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed v8::AssertNoGCScope. Everything was private, so no object could ever be constructed, which implies that nobody uses it. Furthermore, it contained a TODO and was overly complicated, an #ifdef-less simple pimpl idiom would have been enough. LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18493

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -30 lines)			Patch
	M	include/v8.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 11 months ago (2014-01-08 12:22:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18493 (presubmit successful).

Expand Messages | Collapse Messages