Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: ipc/attachment_broker_privileged_win.cc

Issue 1281103002: Add UMA metrics to log attachment broker errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from isherman. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/attachment_broker_privileged_win.cc
diff --git a/ipc/attachment_broker_privileged_win.cc b/ipc/attachment_broker_privileged_win.cc
index 20eb4f3beaaadb2ab31825dce2603f6a26b17d5f..1e644504a07ca81148caaac86a03664d7d15e56d 100644
--- a/ipc/attachment_broker_privileged_win.cc
+++ b/ipc/attachment_broker_privileged_win.cc
@@ -59,8 +59,10 @@ void AttachmentBrokerPrivilegedWin::OnDuplicateWinHandle(
IPC::internal::HandleAttachmentWin::WireFormat wire_format =
base::get<0>(param);
- if (wire_format.destination_process == base::kNullProcessId)
+ if (wire_format.destination_process == base::kNullProcessId) {
+ LogError(NO_DESTINATION);
return;
+ }
HandleWireFormat new_wire_format =
DuplicateWinHandle(wire_format, message.get_sender_pid());
@@ -86,9 +88,11 @@ void AttachmentBrokerPrivilegedWin::RouteDuplicatedHandle(
// forever.
LOG(ERROR) << "Failed to deliver brokerable attachment to process with id: "
<< dest;
+ LogError(DESTINATION_NOT_FOUND);
return;
}
+ LogError(DESTINATION_FOUND);
sender->Send(new AttachmentBrokerMsg_WinHandleHasBeenDuplicated(wire_format));
}

Powered by Google App Engine
This is Rietveld 408576698