Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 12811011: net: move test files out of net/base (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, cbentzel+watch_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

net: move test files out of net/base BUG=70818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188822

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Patch Set 3 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -184 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 1 chunk +1 line, -1 line 0 comments Download
D net/base/net_test_suite.h View 1 chunk +0 lines, -53 lines 0 comments Download
D net/base/net_test_suite.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D net/base/run_all_unittests.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M net/net.gyp View 1 4 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/net_test_suite.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/net_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-15 17:55:47 UTC) #1
eroman
How do you envision this "net/test" directory working? We aren't going to be moving all ...
7 years, 9 months ago (2013-03-15 19:22:07 UTC) #2
Paweł Hajdan Jr.
This follows the save convention as base/test, and helps to avoid non-base dependencies in net/base. ...
7 years, 9 months ago (2013-03-15 19:58:50 UTC) #3
eroman
lgtm
7 years, 9 months ago (2013-03-15 20:52:42 UTC) #4
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-18 21:14:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r188822.

Powered by Google App Engine
This is Rietveld 408576698