Save the GIT hash of HEAD when uploading to rietveld.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import json
@@ skipping 82 matching lines @@
     sys.exit(1)
 
 
 def git_set_branch_value(key, value):
   branch = Changelist().GetBranch()
   if branch:
     git_key = 'branch.%s.%s' % (branch, key)
     RunGit(['config', '--int', git_key, "%d" % value])
 
 
+def git_set_branch_value_str(key, value):

[M-A Ruel, 2013/03/14 13:28:27]

I prefer one function.

cmd = ['config']
if isinstance(value, int):
  cmd.append('--int')
value = str(value)

[Roger Tawa OOO till Jul 10th, 2013/03/14 19:49:42]

Done.

+  branch = Changelist().GetBranch()
+  if branch:
+    git_key = 'branch.%s.%s' % (branch, key)
+    RunGit(['config', git_key, str(value)])
+
+
 def git_get_branch_default(key, default):
   branch = Changelist().GetBranch()
   if branch:
     git_key = 'branch.%s.%s' % (branch, key)
     (_, stdout) = RunGitWithCode(['config', '--int', '--get', git_key])
     try:
       return int(stdout.strip())
     except ValueError:
       pass
   return default
@@ skipping 1168 matching lines @@
                               verbose=options.verbose,
                               change=change)
     if not hook_results.should_continue():
       return 1
     if not options.reviewers and hook_results.reviewers:
       options.reviewers = hook_results.reviewers
 
   print_stats(options.similarity, options.find_copies, args)
   if settings.GetIsGerrit():
     return GerritUpload(options, args, cl)
-  return RietveldUpload(options, args, cl)
+  ret = RietveldUpload(options, args, cl)
+  if ret == 0:

[M-A Ruel, 2013/03/14 13:28:27]

if not ret

[Roger Tawa OOO till Jul 10th, 2013/03/14 19:49:42]

Done.

+    git_set_branch_value_str('last-upload-hash', RunGit(['rev-parse', 'HEAD']))
+
+  return ret
 
 
 def IsSubmoduleMergeCommit(ref):
   # When submodules are added to the repo, we expect there to be a single
   # non-git-svn merge commit at remote HEAD with a signature comment.
   pattern = '^SVN changes up to revision [0-9]*$'
   cmd = ['rev-list', '--merges', '--grep=%s' % pattern, '%s^!' % ref]
   return RunGit(cmd) != ''
 
 
@@ skipping 581 matching lines @@
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))