Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 12811005: Fixing cdm build on Mac OS. (Closed)

Created:
7 years, 9 months ago by dkovalev
Modified:
7 years, 9 months ago
Reviewers:
brettw, ddorwin
CC:
chromium-reviews
Visibility:
Public.

Description

Fixing cdm build on Mac OS. BUG=152864 TEST=cdm build on Mac OS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188370

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing too long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/common/chrome_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/widevine/cdm/widevine_cdm.gyp View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ddorwin
lgtm % comment. Thanks. https://codereview.chromium.org/12811005/diff/1/third_party/widevine/cdm/widevine_cdm.gyp File third_party/widevine/cdm/widevine_cdm.gyp (right): https://codereview.chromium.org/12811005/diff/1/third_party/widevine/cdm/widevine_cdm.gyp#newcode93 third_party/widevine/cdm/widevine_cdm.gyp:93: 'destination': '<(PRODUCT_DIR)/widevinecdmadapter.plugin/Contents/MacOS/', too long
7 years, 9 months ago (2013-03-13 04:48:34 UTC) #1
ddorwin
lgtm
7 years, 9 months ago (2013-03-13 18:38:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkovalev@chromium.org/12811005/3001
7 years, 9 months ago (2013-03-13 19:27:15 UTC) #3
commit-bot: I haz the power
Presubmit check for 12811005-3001 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-13 19:27:17 UTC) #4
dkovalev
brettw, please do a one line review of chrome_paths.cc On 2013/03/13 19:27:17, I haz the ...
7 years, 9 months ago (2013-03-13 20:29:38 UTC) #5
brettw
lgtm
7 years, 9 months ago (2013-03-14 04:29:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkovalev@chromium.org/12811005/3001
7 years, 9 months ago (2013-03-14 19:45:11 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 12:41:28 UTC) #8
Message was sent while issue was closed.
Change committed as 188370

Powered by Google App Engine
This is Rietveld 408576698