Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281083004: ipc: Add the class HandleWin. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add the class HandleWin. HandleWin is a wrapper around a Windows HANDLE that can be transported across IPC channels that support attachment brokering. The attachment broker is responsible for duplicating the HANDLE into the destination process. BUG=493414 Committed: https://crrev.com/959039d06c1677f2d90fc7d84cb9ad9d310842bd Cr-Commit-Position: refs/heads/master@{#342897}

Patch Set 1 #

Patch Set 2 : Win fixes. #

Patch Set 3 : Add logging. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -14 lines) Patch
M ipc/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/attachment_broker_messages.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 chunks +19 lines, -4 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 4 chunks +30 lines, -1 line 0 comments Download
M ipc/attachment_broker_unprivileged_win_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/handle_attachment_win.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M ipc/handle_attachment_win.cc View 2 chunks +9 lines, -5 lines 0 comments Download
A ipc/handle_win.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A ipc/handle_win.cc View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M ipc/ipc.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281083004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281083004/40001
5 years, 4 months ago (2015-08-10 22:51:36 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-10 23:57:13 UTC) #4
erikchen
tsepez: Please review.
5 years, 4 months ago (2015-08-11 00:00:44 UTC) #6
Tom Sepez
lgtm
5 years, 4 months ago (2015-08-11 20:49:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281083004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281083004/40001
5 years, 4 months ago (2015-08-11 21:12:28 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-11 21:17:52 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 21:18:56 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/959039d06c1677f2d90fc7d84cb9ad9d310842bd
Cr-Commit-Position: refs/heads/master@{#342897}

Powered by Google App Engine
This is Rietveld 408576698