Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1281073003: Avoid using two-phase read with MOJO_READ_DATA_FLAG_ALL_OR_NONE. (Closed)

Created:
5 years, 4 months ago by yzshen1
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid using two-phase read with MOJO_READ_DATA_FLAG_ALL_OR_NONE. The issue is that when we get close to the end of data pipe's buffer, the call may fail because the distance between the read cursor to the end of the buffer is smaller than the requested size. In that case, even if the buffer contains sufficient data (possible because it is circular), such a read request will never succeed. Please see https://github.com/domokit/mojo/issues/366 for more details. BUG=513789 Committed: https://crrev.com/c40ee5271fa911b80341a93e318cb90df7354b51 Cr-Commit-Position: refs/heads/master@{#342626}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -22 lines) Patch
M mojo/services/network/public/cpp/web_socket_read_queue.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/public/cpp/web_socket_read_queue.cc View 1 3 chunks +52 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
5 years, 4 months ago (2015-08-07 23:17:41 UTC) #2
jam
lgtm
5 years, 4 months ago (2015-08-10 14:56:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281073003/20001
5 years, 4 months ago (2015-08-10 15:47:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 16:00:06 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 16:00:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c40ee5271fa911b80341a93e318cb90df7354b51
Cr-Commit-Position: refs/heads/master@{#342626}

Powered by Google App Engine
This is Rietveld 408576698