lib/src/solver/version_solver.dart - Issue 1281043004: Make LockFile immutable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/solver/version_solver.dart

Issue 1281043004: Make LockFile immutable. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/solver/version_solver.dart

diff --git a/lib/src/solver/version_solver.dart b/lib/src/solver/version_solver.dart

index d73921404be96286480f2fe4006bddeb5d84039b..9852597a454c89735f357ce35cae1e77f270810a 100644

--- a/lib/src/solver/version_solver.dart

+++ b/lib/src/solver/version_solver.dart

@@ -32,7 +32,7 @@ import 'solve_report.dart';

/// If [upgradeAll] is true, the contents of [lockFile] are ignored.

Future<SolveResult> resolveVersions(SolveType type, SourceRegistry sources,

Package root, {LockFile lockFile, List<String> useLatest}) {

- if (lockFile == null) lockFile = new LockFile.empty();

+ if (lockFile == null) lockFile = new LockFile.empty(sources);

if (useLatest == null) useLatest = [];

return log.progress('Resolving dependencies', () {

« no previous file with comments | « lib/src/lock_file.dart ('k') | test/lock_file_test.dart » ('j') | no next file with comments »