Issue 1281003003: Subzero: Fix a memory leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1281003003: Subzero: Fix a memory leak. (Closed)

Created:
5 years, 4 months ago by Jim Stichnoth

Modified:
5 years, 4 months ago

Reviewers:
jvoung (off chromium), Karl, ascull, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Fix a memory leak. The problem was that Translator and subclasses need to have virtual destructors since they are used as unique_ptr<>. As a result, only the Translator base class destructor was being invoked. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4290 TEST= make -f Makefile.standalone ASAN=1 check-lit R=ascull@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f4fbf7fdff5a40c54a932073209ae9c224d729e3

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
M	src/IceConverter.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceConverter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceTranslator.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceTranslator.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/PNaClTranslator.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

5 years, 4 months ago (2015-08-08 15:37:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
f4fbf7fdff5a40c54a932073209ae9c224d729e3 (presubmit successful).