net/proxy/proxy_config.h - Issue 1280973004: Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config.h

Issue 1280973004: Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_config.h

diff --git a/net/proxy/proxy_config.h b/net/proxy/proxy_config.h

index 90ac96be83ab491a71820af33aa20d157d69cc6d..3716585f9430c1bd41f2867a3cf1ea1e9927a0c0 100644

--- a/net/proxy/proxy_config.h

+++ b/net/proxy/proxy_config.h

@@ -176,7 +176,7 @@ class NET_EXPORT ProxyConfig {

// Creates a Value dump of this configuration. The caller is responsible for

eroman 2015/08/10 22:12:42 Please delete the comment on ownership (as it is n

// deleting the returned value.

- base::DictionaryValue* ToValue() const;

+ scoped_ptr<base::DictionaryValue> ToValue() const;

ProxyRules& proxy_rules() {

return proxy_rules_;

« no previous file with comments | « no previous file | net/proxy/proxy_config.cc » ('j') | no next file with comments »