Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue

net/proxy/proxy_config.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_CONFIG_H_
 #define NET_PROXY_PROXY_CONFIG_H_
 
 #include <string>
 
 #include "net/base/net_export.h"
@@ skipping 156 matching lines @@
   // Returns true if the given config is equivalent to this config.  The
   // comparison ignores differences in |id()| and |source()|.
   bool Equals(const ProxyConfig& other) const;
 
   // Returns true if this config contains any "automatic" settings. See the
   // class description for what that means.
   bool HasAutomaticSettings() const;
 
   void ClearAutomaticSettings();
 
   // Creates a Value dump of this configuration. The caller is responsible for

[eroman, 2015/08/10 22:12:42]

Please delete the comment on ownership (as it is now explicit in the API)

   // deleting the returned value.
-  base::DictionaryValue* ToValue() const;
+  scoped_ptr<base::DictionaryValue> ToValue() const;
 
   ProxyRules& proxy_rules() {
     return proxy_rules_;
   }
 
   const ProxyRules& proxy_rules() const {
     return proxy_rules_;
   }
 
   void set_pac_url(const GURL& url) {
@@ skipping 70 matching lines @@
   ProxyConfigSource source_;
 
   ID id_;
 };
 
 }  // namespace net
 
 
 
 #endif  // NET_PROXY_PROXY_CONFIG_H_