Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1280973002: Speed up tests for optimized code sharing. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speed up tests for optimized code sharing. Note that this tests performed unnecessary many iterations which led to long runtimes in debug mode and also caused flaky GCs during that would cause the optimized code map to be flushed and violated assumptions. R=yangguo@chromium.org BUG=v8:4363 LOG=N Committed: https://crrev.com/e8a399c0a09b344b1f7d18fc340ee2228f6efeec Cr-Commit-Position: refs/heads/master@{#30070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-07 13:17:17 UTC) #1
Yang
On 2015/08/07 13:17:17, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-07 13:18:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280973002/1
5 years, 4 months ago (2015-08-07 13:23:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 13:39:00 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 13:39:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8a399c0a09b344b1f7d18fc340ee2228f6efeec
Cr-Commit-Position: refs/heads/master@{#30070}

Powered by Google App Engine
This is Rietveld 408576698