Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1280913003: Upstreaming browser/ui/uikit_ui_util from iOS. (Closed)

Created:
5 years, 4 months ago by jbbegue
Modified:
5 years, 4 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstreaming browser/ui/uikit_ui_util from iOS. Added AddSameCenterXConstraint which add constraints to a parent view to horizontally align two subviews. Added BOOL IsRTLUILayout() which take into account RTL pseudo language. This will be removed once base::i18n::IsRTL() supports it. BUG=None Committed: https://crrev.com/18831714d344d489908705d374cf8c416afa603d Cr-Commit-Position: refs/heads/master@{#342328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M ios/chrome/browser/ui/uikit_ui_util.h View 2 chunks +13 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbbegue
5 years, 4 months ago (2015-08-07 08:20:18 UTC) #2
sdefresne
lgtm
5 years, 4 months ago (2015-08-07 10:07:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280913003/1
5 years, 4 months ago (2015-08-07 10:07:22 UTC) #5
sdefresne
Rubberstamp lgtm
5 years, 4 months ago (2015-08-07 10:07:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 10:15:56 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 10:16:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18831714d344d489908705d374cf8c416afa603d
Cr-Commit-Position: refs/heads/master@{#342328}

Powered by Google App Engine
This is Rietveld 408576698