Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 128083002: Android: wait for at least one device if usb restart fails. (Closed)

Created:
6 years, 11 months ago by bulach
Modified:
6 years, 11 months ago
Reviewers:
navabi1, navabi
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: wait for at least one device if usb restart fails. On some bots, the USB restart fails, but some devices come back online shortly afterwards. Rather than completely shortcut, wait for at least one device to be alive. BUG=332356 TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244145

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 4 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
ptal
6 years, 11 months ago (2014-01-08 12:19:30 UTC) #1
navabi
lgtm with variable name nit. https://codereview.chromium.org/128083002/diff/30001/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/128083002/diff/30001/build/android/buildbot/bb_device_status_check.py#newcode239 build/android/buildbot/bb_device_status_check.py:239: restarted = True This ...
6 years, 11 months ago (2014-01-09 23:31:38 UTC) #2
bulach
thanks armand! addressed, CQing (TBRing to your chromium since the lg came from google :) ...
6 years, 11 months ago (2014-01-10 09:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/128083002/120001
6 years, 11 months ago (2014-01-10 09:08:39 UTC) #4
commit-bot: I haz the power
Change committed as 244145
6 years, 11 months ago (2014-01-10 11:12:53 UTC) #5
navabi1
6 years, 11 months ago (2014-01-10 20:01:51 UTC) #6
Message was sent while issue was closed.
On 2014/01/10 11:12:53, I haz the power (commit-bot) wrote:
> Change committed as 244145

Thanks Marcus!
lgtm (chromium account)

Powered by Google App Engine
This is Rietveld 408576698