Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1280813003: If there are no local credentials for a locked profile, show sign in button (Closed)

Created:
5 years, 4 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 4 months ago
Reviewers:
bcwhite, xiyuan, achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If there are no local credentials for a locked profile, show sign in button instead of password field. The user will need to reauth online. BUG=514589 Committed: https://crrev.com/e5f477c7d8494811b67f1c4dda4afb6f214cf074 Cr-Commit-Position: refs/heads/master@{#342867}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Fix styling, add C++ code #

Total comments: 2

Patch Set 4 : rebased #

Patch Set 5 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -41 lines) Patch
M chrome/browser/resources/user_manager/user_manager.css View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 3 4 4 chunks +30 lines, -21 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 2 3 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Roger Tawa OOO till Jul 10th
Hi Achuith, Xiyuan, Xiyuan: thanks for the tip about CSS styles and the "sign in" ...
5 years, 4 months ago (2015-08-07 18:39:45 UTC) #3
xiyuan
lgtm
5 years, 4 months ago (2015-08-07 19:56:24 UTC) #4
achuithb
I'm not super-familiar with this code, Roger. It looks ok to me, but maybe Brian ...
5 years, 4 months ago (2015-08-08 00:29:49 UTC) #6
bcwhite
lgtm
5 years, 4 months ago (2015-08-08 15:01:59 UTC) #7
Roger Tawa OOO till Jul 10th
Thanks Achuith. Brian l g t m 'ed, but I still need your owner review ...
5 years, 4 months ago (2015-08-11 15:02:30 UTC) #8
achuithb
lgtm
5 years, 4 months ago (2015-08-11 19:13:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280813003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280813003/100001
5 years, 4 months ago (2015-08-11 19:19:37 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 4 months ago (2015-08-11 19:28:04 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 19:29:10 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e5f477c7d8494811b67f1c4dda4afb6f214cf074
Cr-Commit-Position: refs/heads/master@{#342867}

Powered by Google App Engine
This is Rietveld 408576698