Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1280743003: Add GPU.ANGLE.Buffer11CPUMemoryMB to histograms.xml (Closed)

Created:
5 years, 4 months ago by cwallez
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GPU.ANGLE.Buffer11CPUMemoryMB to histograms.xml This histograms tracks the sum of CPU memory allocations of Buffer11 copies in order to measure the impact of copy pruning methods. BUG=angleproject:516 Committed: https://crrev.com/f2643788070fcf5760705f2f13d0c0f4e24b7971 Cr-Commit-Position: refs/heads/master@{#342355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Corentin Wallez
Trivial addition of an histogram, please take a look.
5 years, 4 months ago (2015-08-06 18:20:10 UTC) #3
rkaplow
lgtm
5 years, 4 months ago (2015-08-06 18:21:01 UTC) #4
Corentin Wallez
On 2015/08/06 18:21:01, rkaplow wrote: > lgtm Thank you for the vast review!
5 years, 4 months ago (2015-08-06 18:22:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280743003/1
5 years, 4 months ago (2015-08-06 18:23:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89845)
5 years, 4 months ago (2015-08-06 20:09:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280743003/1
5 years, 4 months ago (2015-08-06 21:30:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87673)
5 years, 4 months ago (2015-08-06 23:16:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280743003/1
5 years, 4 months ago (2015-08-07 14:28:35 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 15:12:58 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 15:13:45 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2643788070fcf5760705f2f13d0c0f4e24b7971
Cr-Commit-Position: refs/heads/master@{#342355}

Powered by Google App Engine
This is Rietveld 408576698