Issue 128073002: Telemetry: Add speed parameters to swipe and scroll actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128073002: Telemetry: Add speed parameters to swipe and scroll actions. (Closed)

Created:
6 years, 11 months ago by Dominik Grewe

Modified:
6 years, 11 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry: Add speed parameters to swipe and scroll actions. The synthetic swipe and scroll gestures have a parameter that controls the speed of the gesture (in pixels per second). This patch exposes that parameter to the corresponding page actions in Telemetry. BUG=326522 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243861

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -6 lines)			Patch
M	tools/telemetry/telemetry/page/actions/scroll.js	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/scroll.py	View	4 chunks	+7 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/swipe.js	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/swipe.py	View	4 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dominik Grewe

On 2014/01/08 17:28:26, tonyg wrote: > lgtm Thanks!

6 years, 11 months ago (2014-01-08 17:33:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/128073002/1

6 years, 11 months ago (2014-01-08 17:33:20 UTC) #4

Message was sent while issue was closed.

Change committed as 243861

Expand Messages | Collapse Messages