Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issue 1280703002: Use conservative estimate for GC speed instead of bailing out when computing (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use conservative estimate for GC speed instead of bailing out when computing mutator utilization. This makes GC heuristics more robust for small applications that trigger scavenges but do not trigger full GC. BUG= Committed: https://crrev.com/b528d0772bba9bc378c9cc18f624513ccfc7f8e8 Cr-Commit-Position: refs/heads/master@{#30060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 4 months ago (2015-08-06 16:27:39 UTC) #2
Hannes Payer (out of office)
LGTM
5 years, 4 months ago (2015-08-07 08:53:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280703002/1
5 years, 4 months ago (2015-08-07 08:55:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 09:35:40 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 09:35:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b528d0772bba9bc378c9cc18f624513ccfc7f8e8
Cr-Commit-Position: refs/heads/master@{#30060}

Powered by Google App Engine
This is Rietveld 408576698