Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12807006: gm: report drawing mode discrepancies (e.g. pipe vs tiled) explicitly (Closed)

Created:
7 years, 9 months ago by epoger
Modified:
7 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

gm: report drawing mode discrepancies (e.g. pipe vs tiled) explicitly Closed in favor of https://codereview.chromium.org/13650002 ('gm: report ExpectationsMismatch and RenderModeMismatch results separately')

Patch Set 1 #

Total comments: 1

Patch Set 2 : sync_to_r8292 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -40 lines) Patch
M gm/gmmain.cpp View 1 10 chunks +49 lines, -32 lines 1 comment Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
A gm/tests/outputs/pipe-playback-failure/output-expected/command_line View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/pipe-playback-failure/output-expected/json-summary.txt View 1 chunk +33 lines, -0 lines 0 comments Download
A gm/tests/outputs/pipe-playback-failure/output-expected/return_value View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/pipe-playback-failure/output-expected/stderr View 1 chunk +2 lines, -0 lines 0 comments Download
A gm/tests/outputs/pipe-playback-failure/output-expected/stdout View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/tests/run.sh View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
epoger
https://codereview.chromium.org/12807006/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/12807006/diff/1/gm/gmmain.cpp#newcode1 gm/gmmain.cpp:1: /* patchset 1: same as patchset 4 from https://codereview.chromium.org/12825005 ...
7 years, 9 months ago (2013-03-20 19:06:12 UTC) #1
epoger
7 years, 9 months ago (2013-03-21 15:17:12 UTC) #2 
https://codereview.chromium.org/12807006/diff/4001/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/12807006/diff/4001/gm/gmmain.cpp#newcode1
gm/gmmain.cpp:1: /*
patchset 2: no changes, just synced the workspace to r8292

Powered by Google App Engine
This is Rietveld 408576698