Issue 12807004: move impl of AdvancedTypefaceMetrics into typeface (3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12807004: move impl of AdvancedTypefaceMetrics into typeface (3) (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

move impl of AdvancedTypefaceMetrics into typeface (3) Committed: https://code.google.com/p/skia/source/detail?r=8274

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -68 lines)			Patch
M	include/core/SkTypeface.h	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	src/core/SkTypeface.cpp	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType_common.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ports/SkFontHost_mac.cpp	View	4 chunks	+10 lines, -8 lines	0 comments	Download
M	src/ports/SkFontHost_none.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/ports/SkFontHost_simple.cpp	View	2 chunks	+8 lines, -11 lines	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/ports/SkFontHost_win_dw.cpp	View	6 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

7 years, 9 months ago (2013-03-20 17:56:26 UTC) #2

https://codereview.chromium.org/12807004/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/12807004/diff/1/include/core/SkTypeface.h#new...
include/core/SkTypeface.h:211: virtual SkAdvancedTypefaceMetrics*
onGetAdvancedTypefaceMetrics(
public??? ick.

It seems this is currently being used by

chromium/src/third_party/WebKit/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp

just to get the em size. Which is ridiculous because we have an onGetUPEM, and
because of the amount of work being thrown away.

The other user is

chromium/src/printing/pdf_metafile_skia.cc

which is using SkAdvancedTypefaceMetrics::kNotEmbeddable_Font as if it were
named SkAdvancedTypefaceMetrics::kCount_Font just to make a histogram.

Expand Messages | Collapse Messages